fix(TimePicker2): should support custom formatting close ##3651 #4803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YSMJ1994
requested changes
Mar 27, 2024
| @@ -402,7 +402,8 @@ class TimePicker2 extends Component { | |||
|
|
|||
| checkValue = (value, strictly) => { | |||
| const { inputType } = this.state; | |||
| const formatter = v => (typeof v === 'string' ? datejs(v, 'HH:mm:ss') : v); | |||
| const { format } = this.props; | |||
| const formatter = v => (typeof v === 'string' ? datejs(v, format ? format : 'HH:mm:ss') : v); | |||
There was a problem hiding this comment.
props.format 是有默认值的，这里直接用就行了
| assert( | ||
| document.querySelector('li[title="12"][role="option"]').classList.contains('next-selected') | ||
| ); | ||
| }); |
There was a problem hiding this comment.
用例内容与用户实际问题不符，用户的问题是 type "12" 不能选中 12 那一项，一定要 type "12:00:00" 才能匹配 12 那一项
YSMJ1994
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.